Fix LT-20509: Can't delete words with undefined phonemes #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a fix for this, but I'm not sure it is the best solution.
Whenever a word with an undefined phoneme is parsed, a problem report is created for the wordform and added to the language's annotations. This doesn't seem to be used anywhere, but it may be used by clients of FieldWorks. The problem report prevents the user from deleting the wordform, even if the wordform doesn't appear anywhere else. I added code to delete problem reports before trying to decide whether a wordform can be deleted. An alternative is to not create problem reports in the first place. However, this only prevents future problems. It doesn't get rid of existing problem reports.
This change is