Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix LT-20509: Can't delete words with undefined phonemes #166

Merged
merged 8 commits into from
Oct 8, 2024
Merged

Fix LT-20509: Can't delete words with undefined phonemes #166

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
921a4a0
Fix LT-20509: Can't delete words with undefined phonemes
jtmaxwell3 Sep 20, 2024
ef1db87
Merge branch 'release/9.1' into LT-20509
JakeOliver28 Sep 23, 2024
0acf988
Merge branch 'release/9.1' into LT-20509
JakeOliver28 Sep 26, 2024
820611f
Merge branch 'release/9.1' into LT-20509
JakeOliver28 Oct 1, 2024
1a23c3c
Merge branch 'release/9.1' into LT-20509
JakeOliver28 Oct 2, 2024
5e7e75e
Create utility for deleting problem annotations
jtmaxwell3 Oct 3, 2024
109aaca
Remove annotation tests
jtmaxwell3 Oct 3, 2024
2a7d5bb
Merge branch 'release/9.1' into LT-20509
JakeOliver28 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions Src/FdoUi/WfiWordformUi.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@
// This software is licensed under the LGPL, version 2.1 or later
// (http://www.gnu.org/licenses/lgpl-2.1.html)

using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Windows.Forms;

using SIL.LCModel;
using SIL.LCModel.Infrastructure;

namespace SIL.FieldWorks.FdoUi
{
Expand Down Expand Up @@ -76,6 +79,19 @@ protected override bool IsAcceptableContextToJump(string toolCurrent, string too

public override bool CanDelete(out string cannotDeleteMsg)
{
// Delete problem annotations of the word form.
// These aren't used within FieldWorks, and they block deletion.
NonUndoableUnitOfWorkHelper.Do(m_cache.ActionHandlerAccessor, () =>
{
ICmBaseAnnotationRepository repository = base.Object.Cache.ServiceLocator.GetInstance<ICmBaseAnnotationRepository>();
IEnumerable<ICmBaseAnnotation> problemAnnotations =
from ann in repository.AllInstances()
where ann.BeginObjectRA == base.Object && ann.SourceRA is ICmAgent
select ann;
foreach (ICmBaseAnnotation problem in problemAnnotations)
m_cache.DomainDataByFlid.DeleteObj(problem.Hvo);
});

if (base.CanDelete(out cannotDeleteMsg))
return true;
cannotDeleteMsg = FdoUiStrings.ksCannotDeleteWordform;
Expand Down
Loading