ENH Update reference to supported modules data #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also don't override error alert list.
GuySartorelli
commented
May 7, 2024
Comment on lines
-38
to
+37
| fi | ||
| else |
There was a problem hiding this comment.
This (and the related indentation change) is unrelated - but I noticed we set ALERTS_LIST to indicate failed JSON fetching above but then we just continue as though we didn't just identify an error.
Now we only try to use the json content if we didn't already detect it was faulty.
There was a problem hiding this comment.
I recommend adding ?w=1 to the URL when viewing the diff so you can ignore whitespace and just see what's actually materially changed in this PR.
emteknetnz
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue