ENH Use repositories from supported-modules #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
emteknetnz
force-pushed
the
pulls/main/supported-modules
branch
from
1918d01
to
6fcd800
Compare
emteknetnz
commented
May 8, 2024
| @@ -119,7 +118,7 @@ abstract protected function fetchDataFromApi(string $path, string $postBody = '' | |||
|
|
|||
| protected function getMethod(string $postBody): string | |||
| { | |||
| return $postBody ? Consts::METHOD_POST : Consts::METHOD_GET; | |||
| return $postBody ? 'post' : 'get'; | |||
There was a problem hiding this comment.
This is unrelated refactoring
emteknetnz
commented
May 8, 2024
| @@ -29,7 +28,7 @@ protected function fetchDataFromApi(string $path, string $postBody = ''): string | |||
| $url = $apiConfig->deriveUrl($path, $offset); | |||
| Logger::singleton()->log("REST {$ucMethod} {$url}"); | |||
| curl_setopt($ch, CURLOPT_URL, $url); | |||
| if ($method == Consts::METHOD_POST) { | |||
| if (strtolower($method) == 'post') { | |||
There was a problem hiding this comment.
This is unrelated refactoring
emteknetnz
force-pushed
the
pulls/main/supported-modules
branch
from
6fcd800
to
f1c63ac
Compare
emteknetnz
commented
May 8, 2024
| @@ -2,7 +2,6 @@ | |||
|
|
|||
| namespace { | |||
|
|
|||
| use App\DataFetcher\Models\ApiData; | |||
There was a problem hiding this comment.
Unrelated refactoring, unused import
emteknetnz
force-pushed
the
pulls/main/supported-modules
branch
2 times, most recently
from
128513e
to
fe8acf6
Compare
GuySartorelli
requested changes
May 8, 2024
emteknetnz
force-pushed
the
pulls/main/supported-modules
branch
from
fe8acf6
to
a7bc573
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #3
I also did some unrelated refactoring to get rid of the pointless get/post consts so that I could delete Consts.php
I've done work to not show unsupported modules in ci builds table e.g. ckan build will show for CMS 4, but not for CMS 5
I have not done the same for merge-ups as there's now shared logic between gha-merge-up and rhino, so the CMS 5 branches for ckan will still show. I personally don't think this is too big of a deal, though if we want to fix this we should do this as a separate card as gha-merge-up would need to be updated as well and this card is only for rhino.