Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use silverstripe/supported-modules #3

Closed
1 task done
emteknetnz opened this issue Oct 10, 2023 · 6 comments
Closed
1 task done

Use silverstripe/supported-modules #3

emteknetnz opened this issue Oct 10, 2023 · 6 comments
Assignees

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Oct 10, 2023

Currently rhino runs off a hardcoded list for the modules it pulls information for

This isn't great because it includes some unsupported modules in the builds list and we waste time remedying them

It should instead use silverstripe/supported-modules

Note that silverstripe/supported-modules doesn't list some repositories we care about such as the gha* repositories. Either they should be added to the supported-modules JSON, or we need to keep them hardcoded here. - That's no longer relevant as of #17

Acceptance criteria

  • Rhino is updated to fetch supported modules from silverstripe/supported-modules repo
  • Rhino honours considers the difference in support levels between CMS 4 and CMS 5.
  • confluence docs about setting up new repos doesn't explicitly mention Rhino, since that's covered by supported-modules.
    • Note that the version of the supported modules repo we'll get will be locked into the composer.lock file... maybe update these docs to run composer update silverstripe/supported-modules in rhino and redeploy it.

PRs

Post merge supported-modules PR

  • Run composer update again and create a new rhino PR and deploy that
@GuySartorelli
Copy link
Member

GuySartorelli commented Feb 20, 2024

There's a // remove any < 4 minor and major branches for linkfield hack in there right now which can be removed once we're doing this, since linkfield only has one supported branch.

Note that we will need to add a 6 branch to the supported modules repo to avoid a regression of #12

@emteknetnz
Copy link
Member Author

emteknetnz commented Mar 26, 2024

We should keep things silverstripe/cwp-search where there was a CMS 5 unsupported version released in the CMS 4 builds but exclude them from the CMS 5 builds

@GuySartorelli
Copy link
Member

PR merged.
Reassigning to Steve to deploy, and to update https://silverstripe.atlassian.net/wiki/spaces/CMS/pages/3030679981/Setting+up+a+new+GitHub+repository

@GuySartorelli
Copy link
Member

PR merged. Reassigning to Steve to deploy

@GuySartorelli
Copy link
Member

New PR merged. Reassigned to Steve for deployment.

@emteknetnz
Copy link
Member Author

Have tested builds + merge-up jobs on UAT, all working. Have deployed to prod. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants