Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Skip modules that should not be merged-up #31

Merged
merged 1 commit into from
May 16, 2024
Merged

FIX Skip modules that should not be merged-up #31

merged 1 commit into from
May 16, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented May 16, 2024 •
edited
Loading

Issue silverstripe/rhino#3

Required for the rhino merge-ups job to run

After merging create a new PR in rhino do ensure that composer.lock is updated so that it receives this update

@emteknetnz emteknetnz mentioned this pull request May 16, 2024
Closed
1 task
GuySartorelli
GuySartorelli approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay. undefinedoffset/sortablegridfield should arguably be in the DO_NOT_MERGE_UP_FROM_MAJOR list instead, but since that module isn't supported for CMS 5 it's fine as is.

@GuySartorelli GuySartorelli merged commit e8f909b into silverstripe:main May 16, 2024
8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/main/skip branch May 16, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli