API Change public CMSEditLink to protected updateCMSEditLink #1809
+21
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 15, 2024
GuySartorelli
force-pushed
the
pulls/3/standardise-cmseditlink
branch
from
4a813d5
to
a9faef1
Compare
emteknetnz
requested changes
Aug 22, 2024
There was a problem hiding this comment.
Pending question on silverstripe/silverstripe-framework#11338 (review)
emteknetnz
requested changes
Aug 22, 2024
code/Forms/UsedOnTable.php
Outdated
| @@ -102,7 +102,7 @@ public function usage(HTTPRequest $request) | |||
| 'id' => $dataObject->ID, | |||
| 'title' => $dataObject->getTitle() ?: _t(__CLASS__ . '.UNTITLED', 'Untitled'), | |||
| 'type' => ucfirst($dataObject->i18n_singular_name() ?? ''), | |||
| 'link' => $dataObject->hasMethod('CMSEditLink') ? $dataObject->CMSEditLink() : null, | |||
| 'link' => $dataObject->CMSEditLink(), | |||
There was a problem hiding this comment.
Suggested change
| 'link' => $dataObject->CMSEditLink(), | |
| 'link' => $dataObject->getCMSEditLink(), |
code/Forms/UsedOnTable.php
Outdated
| @@ -115,7 +115,7 @@ public function usage(HTTPRequest $request) | |||
| foreach ($ancestorDataObjects as $ancestorDataObject) { | |||
| $tableRowData['ancestors'][] = [ | |||
| 'title' => $ancestorDataObject->getTitle() ?: _t(__CLASS__ . '.UNTITLED', 'Untitled'), | |||
| 'link' => $ancestorDataObject->hasMethod('CMSEditLink') ? $ancestorDataObject->CMSEditLink() : null, | |||
| 'link' => $ancestorDataObject->CMSEditLink(), | |||
There was a problem hiding this comment.
Suggested change
| 'link' => $ancestorDataObject->CMSEditLink(), | |
| 'link' => $ancestorDataObject->getCMSEditLink(), |
| @@ -28,7 +28,7 @@ public function getMimeType() | |||
| return 'text/html'; | |||
| } | |||
|
|
|||
| public function CMSEditLink() | |||
| public function CMSEditLink(): ?string | |||
There was a problem hiding this comment.
Suggested change
| public function CMSEditLink(): ?string | |
| public function getCMSEditLink(): ?string |
GuySartorelli
force-pushed
the
pulls/3/standardise-cmseditlink
branch
from
a9faef1
to
e048241
Compare
GuySartorelli
force-pushed
the
pulls/3/standardise-cmseditlink
branch
from
e048241
to
c786f81
Compare
emteknetnz
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on changes made in silverstripe/silverstripe-framework#11338
Issue