FEAT update CMS fields to allow user-specific permissions #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewandante
force-pushed
the
FEAT_add_cms_interface_for_user_inherited_permission
branch
from
5f59429
to
612b9f4
Compare
andrewandante
force-pushed
the
FEAT_add_cms_interface_for_user_inherited_permission
branch
from
612b9f4
to
9b8de6f
Compare
GuySartorelli
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
We really need a core implementation of displaylogic that works in both entwine and react contexts 😅 But that's way out of scope - for now continuing to show the fields is suboptimal but acceptable.
This works great locally. Will merge after the assets and framework PRs are both good to go.
GuySartorelli
requested changes
Jul 6, 2023
andrewandante
force-pushed
the
FEAT_add_cms_interface_for_user_inherited_permission
branch
from
9b8de6f
to
d48f81d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion to silverstripe/silverstripe-framework#10819 and silverstripe/silverstripe-assets#556
Adds CMS field to Asset admin to allow for user-specific permission management.
Issue