ONLY_THESE_USERS is poorly named and not as useful as it should be

[andrewandante]

Affected Version

CMS all of them

Description

The scope of InheritedPermissions::ONLY_THESE_USERS doesn't do what it says on the tin; instead, this functionality is better described as "only these GROUPS". Equally, this means you can't assign a specific user access to anything in this way - you have to jump through hoops to add them to a group first, which is often unnecessary double-handling.

Proposal

Minor release: add a new permission InheritedPermissions::ONLY_THESE_INDIVIDUAL_USERS that allows mapping to many Users, instead of groups. Mark this permission and the existing permission as deprecated. This adds the new functionality without breaking the existing API.

Major release: rename the above as follows:

InheritedPermissions::ONLY_THESE_USERS => InheritedPermissions::ONLY_THESE_GROUPS

InheritedPermissions::ONLY_THESE_INDIVIDUAL_USERS => InheritedPermissions::ONLY_THESE_USERS

PRs

• NEW add OnlyTheseMembers Inherited Permission type #10819
• add check for specific user inherited permission silverstripe-assets#556
• FEAT update CMS fields to allow user-specific permissions silverstripe-asset-admin#1369
• FEAT update SiteTree permissions in CMS silverstripe-cms#2862
• ENH hide permission fields we arent using silverstripe-admin#1531
• DOC Document new "Only these users" permission developer-docs#298

ListboxField React PRs

• NEW add ListboxField react component silverstripe-admin#1533
• NEW ListboxField react field schema #10842

[sunnysideup]

and the individual users would have a MANY MANY relationship to the Object?

[andrewandante]

As per comment here: #10819 (comment) there's now a demo repo with all these PRs in one place: https://github.com/andrewandante/silverstripe-only-this-user-demo/blob/main/composer.json#L11-L23

[GuySartorelli]

@andrewandante FYI this has now progressed from todo to in progress, so I'll be reviewing the PRs more thoroughly today. I've given them only quick glances until now to check for anything obvious - so there may be a few more changes requested.

[GuySartorelli]

Thank you for this @andrewandante, this is a great contribution! It'll be released with 5.1 - we're aiming for an October release at the moment.

I've linked a docs PR to the issue description which someone else in the team will review.

[andrewandante]

Magic, thanks so much for your guidance and patience! Onward!

[emteknetnz]

Have merged docs PR

[sunnysideup]

THANK you SO MUCH