FEAT update SiteTree permissions in CMS

[andrewandante]

Linked to silverstripe/silverstripe-framework#10819

Allows SiteTree objects to have permissions assigned to a individual users, rather than having to assign it directly to groups.

Issue

• ONLY_THESE_USERS is poorly named and not as useful as it should be silverstripe-framework#10817

[andrewandante]

This is now all working alongside the Framework PR; however, the ViewerMembers and EditorMembers fields always show in the CMS, instead of dynamically show/hide depending on the ViewType/EditType. Can't seem to pinpoint what is doing that, any tips?

EDIT: Oh no, it's entwine? https://github.com/silverstripe/silverstripe-cms/pull/1747/files#diff-f8b125682490aaedb06618d1784af3223e62462cade2ad266673d6688399ca56R205-R237

EDIT EDIT: Fixed over here: https://github.com/silverstripe/silverstripe-admin/pull/1531/files

[GuySartorelli]

There's a couple of PHP linting issues in the CI run which need to be ironed out, please

[GuySartorelli]

Just one small change here, otherwise it all looks okay to me

[GuySartorelli]

For some reason when I try this locally, the Viewer Users and Editor Users fields don't save. It's probably more to do with the changes you made to ListboxField than anything here, but given that's merged already I'll put the note here instead.
Can you please investigate and assuming you can reproduce this, find out where that bug's coming from? The value is being passed in as part of the form submission request, I can see that from my browser.

It does work fine in react contexts - just the entwine context that's borked.

[andrewandante]

Can you please investigate and assuming you can reproduce this, find out where that bug's coming from?

Yep can reproduce, I saw it last night and have spent a decent chunk of today implementing XDebug in a new dev environment 😅 so I'll see what I can find - I think it's likely do with the validation step. Thanks for all your reviewing thus far!

[andrewandante]

This Framework commit I think fixes the issue - locally I now have both the entwine and react versions working 🤞

[GuySartorelli]

LGTM