Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TopPage classnames #1240

Closed
3 tasks
emteknetnz opened this issue Aug 20, 2024 · 2 comments
Closed
3 tasks

Update TopPage classnames #1240

emteknetnz opened this issue Aug 20, 2024 · 2 comments
Assignees
@GuySartorelli
Labels
type/api-break

Comments

@emteknetnz
Copy link
Member

emteknetnz commented Aug 20, 2024 •
edited
Loading

The TopPage feature uses a non-standard directory and class name structure. This should be changed to adopt the standard Silverstripe naming conventions

Acceptance criteria

  • The TopPage feature classes adopt the standard Silverstripe naming convention in CMS 6
  • In CMS 5 old class names are deprecated and wrapping in withNoReplacement. The message should be "Will be replaced with "
  • Any documentation referring to TopPage is updated

Kitchen sink CI

CMS 5 PRs

CMS 6 PRs - Ensure CMS 5 PR's are merged, merged-up and rebased first
@emteknetnz emteknetnz self-assigned this Sep 3, 2024
This was referenced Sep 4, 2024
Closed
Merged
Merged
@emteknetnz emteknetnz removed their assignment Sep 4, 2024
@emteknetnz emteknetnz mentioned this issue Sep 4, 2024
Merged
This was referenced Sep 5, 2024
Merged
Merged
@GuySartorelli
Copy link
Member

CMS 5 PRs merged. Reassigning to Steve for CMS 6 PRs

@emteknetnz emteknetnz removed their assignment Sep 10, 2024
@GuySartorelli
Copy link
Member

PRs merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
type/api-break
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emteknetnz @GuySartorelli