Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Rename TopPage classes #1249

Merged
merged 1 commit into from
Sep 10, 2024
Merged

API Rename TopPage classes #1249

merged 1 commit into from
Sep 10, 2024

Conversation

emteknetnz
Copy link
Member

Issue #1240

@emteknetnz emteknetnz mentioned this pull request Sep 4, 2024
Closed
3 tasks
GuySartorelli
GuySartorelli approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when other PR is approved

@emteknetnz emteknetnz marked this pull request as draft September 4, 2024 23:24
@GuySartorelli GuySartorelli mentioned this pull request Sep 4, 2024
Merged
@emteknetnz emteknetnz marked this pull request as ready for review September 10, 2024 01:14
GuySartorelli
GuySartorelli approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit f2f2fde into silverstripe:6 Sep 10, 2024
24 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/rename-toppage branch September 10, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli