Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Use Updated names of top page extensions #326

Closed
wants to merge 1 commit into from
Closed

FIX Use Updated names of top page extensions #326

wants to merge 1 commit into from

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Sep 4, 2024
Closed
3 tasks
@emteknetnz
Copy link
Member Author

Have validated locally that hasExtension() will perform an is_a() check that will check for subclasses. Don't need this PR

@emteknetnz emteknetnz closed this Sep 4, 2024
@emteknetnz
Copy link
Member Author

Actually we do 😆 renamed the class, re-opening, and have removed the check for the fluent class

@emteknetnz
Copy link
Member Author

Wouldn't let me reopen as I had force pushed over the last commit, and opened this instead #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli