NEW ListboxField react field schema #10842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 28, 2023
|
Unit test failures seem relevant |
GuySartorelli
requested changes
Jul 3, 2023
andrewandante
force-pushed
the
ENH_add_listboxfield_react_component_schema
branch
3 times, most recently
from
7f32db5
to
4037f21
Compare
andrewandante
force-pushed
the
ENH_add_listboxfield_react_component_schema
branch
from
4037f21
to
e1d10a0
Compare
|
Think we are there now:
|
GuySartorelli
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the required methods for ListboxField to have a React Component (in this case, for asset-admin)
Companion PR to silverstripe/silverstripe-admin#1533
Blocker for #10819
Issue