API Standardise extension hooks (#465)

silverstripe · Aug 27, 2024 · c2d37cc · c2d37cc
1 parent eab840e
commit c2d37cc
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/Dev/VersionedTestSessionExtension.php b/src/Dev/VersionedTestSessionExtension.php
@@ -19,7 +19,7 @@ class VersionedTestSessionExtension extends VersionedStateExtension
      *
      * @param string $url
      */
-    public function updateLink(&$url)
+    protected function updateLink(&$url)
     {
         $session = $this->owner->session();
         if (!$session) {

diff --git a/src/Versioned.php b/src/Versioned.php
@@ -1589,7 +1589,7 @@ protected function extendcanRestoreToDraft()
      * @param Member $member
      * @return bool|null
      */
-    public function canView($member = null)
+    protected function canView($member = null)
     {
         // Invoke default version-gnostic canView
         if ($this->owner->canViewVersioned($member) === false) {
@@ -2888,7 +2888,7 @@ protected function onBeforeDuplicate($source, $doWrite)
         $this->owner->Version = 0;
     }
 
-    public function flushCache()
+    protected function onFlushCache()
     {
         Versioned::$cache_versionnumber = [];
         $this->versionModifiedCache = [];

diff --git a/src/VersionedStateExtension.php b/src/VersionedStateExtension.php
@@ -30,7 +30,7 @@ class VersionedStateExtension extends Extension
      *
      * @param string $link
      */
-    public function updateLink(&$link)
+    protected function updateLink(&$link)
     {
         // Skip if link already contains reading mode
         if ($this->hasVersionedQuery($link)) {

diff --git a/tests/php/VersionedTest/PublicExtension.php b/tests/php/VersionedTest/PublicExtension.php
@@ -10,7 +10,7 @@
  */
 class PublicExtension extends DataExtension implements TestOnly
 {
-    public function canViewNonLive($member = null)
+    protected function canViewNonLive($member = null)
     {
         return true;
     }