Feature/reviews improvements #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new password request mailing template - cleaned several files with phpDoc corrections
…ge if referer is not an AJAX request - even if it works, please note this behaves strangely and must be checked regularly
…ADME.md which will probably need to be reviewed to add Code Climate quality badge
…commended file to adapt code
…n recommended file to adapt code - upgraded also other packages declared in composer.json
…e them available despite the fact it is not a good idea to push such files on GitHub
…ile instead of simple array
…n which will probably need to be reviewed
…es depending on similar context
…ack to make loading page performance better
….yaml file instead of simple array
…ng a manual CSRF token validation - used clean DELETE HTTP method with generic entity deletion JS file - updated Twig templates to add a user deletion link and a user deletion confirmation modal on update profile form page
…initial check to possibly show LOAD MORE button depending on first level trick comments total count and comment number per loading parameter comparison condition
…atibility due to changes made in class since Sf 4.3
… lines as it is recommended in PHP PSR-12
…ror for common errors standard template to be called for 500, 404, ... status code - updated cookies configuration for Sf 4.4
…ted user main role to avoid issue
… event listener on AJAX response
… ternary operator format on trick update form
|
Merge accepted! Thanks a lot for all the features added to application, to make user experience better and more realistic! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch creates some project improvements and fixes latest detected bugs.
This merge aims at testing better workflow with development and features branches added to master. No issue is referenced for this pull request.
This branch treated expected changes and "fixed" issue: #20
Upgraded Symfony from 4.2 version to 4.4 LTS version and adapted code where it was necessary
Fixed PHPUnit Symfony bridge due to this upgrade
Added user account deletion action with AJAX confirmation modal without form but with CSRF token and DELETE request
Fixed a minor bug with referer redirection as concerns login authenticator manager
Simplified redundant responder classes and reviewed references to templates with a .yaml file
Separated JS scripts in multiple files to improve page loading.
Made several improvements on application to make UX better and fixed a few bugs
Reformatted PHP code with PSR-1 / PSR-12
Cleaned some PHP and JS scripts and phpDoc
Added a few unit tests and described project local installation
Message: please accept this merge, this is the first project version to be ready for production!