Remove commented-out code and placeholder comments from exchange_hankel.py #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…el.py Co-authored-by: skilledwolf <18141588+skilledwolf@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP address comments on sign/indexing fixes and performance improvements
Remove commented-out code and placeholder comments from exchange_hankel.py
Dec 3, 2025
skilledwolf
approved these changes
Dec 3, 2025
There was a problem hiding this comment.
Pull request overview
This PR performs code cleanup in exchange_hankel.py by removing commented-out code and placeholder comments that were left over from development or debugging. The changes improve code readability and maintainability without affecting functionality.
Key Changes:
- Removed commented-out alternative implementations in helper functions
- Corrected an inline comment to accurately describe the mathematical formula
(i)^(d1+d2) - Removed a placeholder comment about magnetic field changes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback to clean up dead code and uninformative comments in
exchange_hankel.py.Changes
_N_orderand_parity_factorfunctionsphase_internal_tableline# CHANGED HERE NEGATIVE B FIELD(i)^(d1+d2)(was incorrectly(i)^(d1-d2))💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.