Skip to content

Remove commented-out code and placeholder comments from exchange_hankel.py #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skilledwolf merged 2 commits into from
Dec 3, 2025
Merged

Remove commented-out code and placeholder comments from exchange_hankel.py #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a2ee53
Initial plan
Copilot Dec 3, 2025
32e29d9
Remove commented-out code and placeholder comments from exchange_hank…
Copilot Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/quantumhall_matrixelements/exchange_hankel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,9 @@


def _N_order(n1: int, m1: int, n2: int, m2: int) -> int:
#return (n1 - m1) - (m2 - n2)
return ((n1 - m1) + (m2 - n2))

def _parity_factor(N: int) -> int:
#return (-1) ** ((N + abs(N)) // 2)
return (-1) ** ((N - abs(N)) // 2)

@lru_cache(maxsize=None)
Expand Down Expand Up @@ -141,9 +139,8 @@ def get_exchange_kernels_hankel(
phase = -N * G_angles
phase_by_N[int(N)] = (np.cos(phase) + 1j * np.sin(phase)) * _parity_factor(int(N))

# Small lookup for internal (i)^(d1-d2), indexed by d1,d2 in [0..nmax-1]
# Small lookup for internal (i)^(d1+d2), indexed by d1,d2 in [0..nmax-1]
d_vals = np.arange(nmax, dtype=int)
#phase_internal_table = (1j) ** (d_vals[:, None] - d_vals[None, :]) # (nmax,nmax)
phase_internal_table = (1j) ** (d_vals[:, None] + d_vals[None, :]) # (nmax,nmax)

d_lookup = np.abs(np.subtract.outer(np.arange(nmax), np.arange(nmax))) # (nmax,nmax)
Expand Down Expand Up @@ -197,7 +194,7 @@ def integrand(q):
# Angular/internal phases
phase_internal = phase_internal_table[d1, d2]
phase_angle = phase_by_N[N]
extra_sgn = (-1)**(n2-m2) # CHANGED HERE NEGATIVE B FIELD
extra_sgn = (-1)**(n2-m2)

Xs[:, n1, m1, n2, m2] = phase_internal * phase_angle * X_radial * extra_sgn

Expand Down
Loading