-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting grpc send and recv message sizes independently #481
Conversation
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this lgtm! I think we'll want to update all the txt help files with the two new flags to get some of the unit tests passing. Since they all use these grpc common options topo2topo.txt |
@pbibra where are those files? I don't see them in my slack-15 checkout (alternatively, which tests should I run locally to trigger those failures?) |
Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>
@pbibra I found some of them, let me know if others (like topo2topo.txt) still need updating. |
Signed-off-by: Priya Bibra <pbibra@slack-corp.com>
No sorry! That list was from the v19 branch - you got all of them here! The tests are in
|
* Allow setting grpc send and recv message sizes independently Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Add comments Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Update .txt files Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * update help txt ordering Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com>
…ntly (#481) (#540) * Allow setting grpc send and recv message sizes independently (#481) * Allow setting grpc send and recv message sizes independently Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Add comments Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Update .txt files Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * update help txt ordering Signed-off-by: Priya Bibra <pbibra@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com> * remove vtgr * fix test * fix spaces --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> Signed-off-by: Priya Bibra <pbibra@slack-corp.com> Co-authored-by: Henry Robinson <hrobinson@slack-corp.com> Co-authored-by: Priya Bibra <pbibra@slack-corp.com>
We would like to set the send and recv max message sizes independently on vtgates. This allows us to keep a small limit on the size of the messages received from tablets, while allowing vtgates to send a large aggregated response to clients.
Two new flags are added:
grpc_max_message_send_size
andgrpc_max_message_recv_size
. These are 0 by default, in which case the existinggrpc_max_message_size
flag is used with no change from the existing behaviour. If set to non-0, they override the setting forgrpc_max_message_size
.