DRAFT: Make internal::core::graphics::color types more sensible #9820
+202
−170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is a DRAFT, but be careful not to change the public API. |
Fair enough, I'll restore the old structs/functions and mark them as deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our
Colortype is quantized to 8 bits for no good reason. I thought I'd change it to use floating point values between 0.0 and 1.0, as well as introduce explicitly quantized color types (one encoded using the sRGB transfer function and another quantized linearly). This will require a lot of code changes elsewhere and will probably not get merged any time soon.