Skip to content

DRAFT: Make internal::core::graphics::color types more sensible #9820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
+202 −170
Draft

DRAFT: Make internal::core::graphics::color types more sensible #9820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0f33a6a
Change Color type to be f32
expenses Oct 22, 2025
9e4611e
Add quantized types, documentation
expenses Oct 22, 2025
ca01bc5
Add back stuff but as deprecated
expenses Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions internal/core/graphics/brush.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,12 +64,12 @@ impl Brush {
/// ```
/// # use i_slint_core::graphics::*;
/// assert!(Brush::default().is_transparent());
/// assert!(Brush::SolidColor(Color::from_argb_u8(0, 255, 128, 140)).is_transparent());
/// assert!(!Brush::SolidColor(Color::from_argb_u8(25, 128, 140, 210)).is_transparent());
/// assert!(Brush::SolidColor(Color::from_argb_f32(0.0, 1.0, 0.9, 0.8)).is_transparent());
/// assert!(!Brush::SolidColor(Color::from_argb_f32(0.25, 1.0, 0.9, 0.8)).is_transparent());
/// ```
pub fn is_transparent(&self) -> bool {
match self {
Brush::SolidColor(c) => c.alpha() == 0,
Brush::SolidColor(c) => c.alpha() == 0.0,
Brush::LinearGradient(_) => false,
Brush::RadialGradient(_) => false,
Brush::ConicGradient(_) => false,
Expand All @@ -81,15 +81,15 @@ impl Brush {
/// ```
/// # use i_slint_core::graphics::*;
/// assert!(!Brush::default().is_opaque());
/// assert!(!Brush::SolidColor(Color::from_argb_u8(25, 255, 128, 140)).is_opaque());
/// assert!(Brush::SolidColor(Color::from_rgb_u8(128, 140, 210)).is_opaque());
/// assert!(!Brush::SolidColor(Color::from_argb_f32(0.1, 1.0, 0.5, 0.6)).is_opaque());
/// assert!(Brush::SolidColor(Color::from_rgb_f32(0.5, 0.6, 0.7)).is_opaque());
/// ```
pub fn is_opaque(&self) -> bool {
match self {
Brush::SolidColor(c) => c.alpha() == 255,
Brush::LinearGradient(g) => g.stops().all(|s| s.color.alpha() == 255),
Brush::RadialGradient(g) => g.stops().all(|s| s.color.alpha() == 255),
Brush::ConicGradient(g) => g.stops().all(|s| s.color.alpha() == 255),
Brush::SolidColor(c) => c.alpha() == 1.0,
Brush::LinearGradient(g) => g.stops().all(|s| s.color.alpha() == 1.0),
Brush::RadialGradient(g) => g.stops().all(|s| s.color.alpha() == 1.0),
Brush::ConicGradient(g) => g.stops().all(|s| s.color.alpha() == 1.0),
}
}

Expand Down Expand Up @@ -429,9 +429,9 @@ impl InterpolatedPropertyValue for Brush {
#[allow(clippy::float_cmp)] // We want bit-wise equality here
fn test_linear_gradient_encoding() {
let stops: SharedVector<GradientStop> = [
GradientStop { position: 0.0, color: Color::from_argb_u8(255, 255, 0, 0) },
GradientStop { position: 0.5, color: Color::from_argb_u8(255, 0, 255, 0) },
GradientStop { position: 1.0, color: Color::from_argb_u8(255, 0, 0, 255) },
GradientStop { position: 0.0, color: Color::from_argb_f32(1.0, 1.0, 0.0, 0.0) },
GradientStop { position: 0.5, color: Color::from_argb_f32(1.0, 0.0, 1.0, 0.0) },
GradientStop { position: 1.0, color: Color::from_argb_f32(1.0, 0.0, 0.0, 1.0) },
]
.into();
let grad = LinearGradientBrush::new(256., stops.clone());
Expand Down
Loading
Loading