fix(map): bugs in map package #1166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SVA-1399
- added `clusteringEnabled` prop as `false` to solve the problem of collapsable closing when the map component in `LocationSettings` clicks somewhere other than the coordinates inside the bounds array SVA-1399
- added `anchor` prop to `PointAnnotation` component to fix the problem that the marker is not positioned correctly after clicking on the map - added `zIndex` style to `markerContainer` to fix the problem of markers not displaying correctly for android - added `undefined` value to `onMarkerPress` function when zoom value is changed in `onRegionDidChange` prop to fix the bug that callout text continues to be shown when zoomIn or zoomOut on the map SVA-1399
- added `onDidFinishLoadingMap` prop to `MapView` to prevent the map from being shown without loading and updated `isLoading` to `false` - added style to `Collapsible` component to solve the problem of collapsible buttons overlapping after loading the map on the settings screen - improved code readability SVA-1399
SVA-1399
- refactored code to be more decoupled in effects - added timeout to setting markers which had positive outcomes regarding map reactivity and usability (drag & zoom) SVA-1399
- set default zoom to one marker zoom to not have one step difference between initial zoom and zoom after click in map SVA-1399
SVA-1399
ardasnturk
force-pushed
the
fix/SVA-1399-fix-bugs-in-map-package
branch
from
2060632
to
278f6bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVA-1399