Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map): bugs in map package #1166

Open
wants to merge 9 commits into
base: refactor/SVA-1365-change-map-package
Choose a base branch
from

Commits on Jul 24, 2024

  1. refactor(map): remove unused code

    SVA-1399
    ardasnturk committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    858a371 View commit details
    Browse the repository at this point in the history
  2. fix(map): collapsable in settings closes when clicking on map

    - added `clusteringEnabled` prop as `false` to solve the problem of collapsable closing when the map component in `LocationSettings` clicks
      somewhere other than the coordinates inside the bounds array
    
    SVA-1399
    ardasnturk committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    96d5d7c View commit details
    Browse the repository at this point in the history
  3. fix(map): the problem that the pin is not positioned correctly

    - added `anchor` prop to `PointAnnotation` component to fix the problem that the marker is not positioned
      correctly after clicking on the map
    - added `zIndex` style to `markerContainer` to fix the problem of markers not displaying correctly for android
    - added `undefined` value to `onMarkerPress` function when zoom value is changed in `onRegionDidChange` prop to
      fix the bug that callout text continues to be shown when zoomIn or zoomOut on the map
    
    SVA-1399
    ardasnturk committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    30685ec View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. fix(map): the problem of showing map without loading

    - added `onDidFinishLoadingMap` prop to `MapView` to prevent the map from being shown without loading and updated `isLoading` to `false`
    - added style to `Collapsible` component to solve the problem of collapsible buttons overlapping after loading the map on the settings screen
    - improved code readability
    
    SVA-1399
    ardasnturk committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d280fa2 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. fix(map): remove unused code

    SVA-1399
    donni106 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    60790d3 View commit details
    Browse the repository at this point in the history
  2. fix(map): add timeout to make on marker maps reactive

    - refactored code to be more decoupled in effects
    - added timeout to setting markers which had positive
      outcomes regarding map reactivity and usability
      (drag & zoom)
    
    SVA-1399
    donni106 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    93ee7fa View commit details
    Browse the repository at this point in the history
  3. fix(map): deactivate rotation of map

    SVA-1399
    donni106 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    816d22e View commit details
    Browse the repository at this point in the history
  4. fix(map): set marker in location settings

    - set default zoom to one marker zoom to
      not have one step difference between initial
      zoom and zoom after click in map
    
    SVA-1399
    donni106 committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    6dbe6f5 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. fix(map): more accurate rendering

    SVA-1399
    donni106 authored and ardasnturk committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    278f6bd View commit details
    Browse the repository at this point in the history