Skip child replace for new query compilation stage if the child has been updated already #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-yzou
requested review from
sfc-gh-yixie,
sfc-gh-yuwang and
sfc-gh-aalam
sfc-gh-yzou
added
the
NO-CHANGELOG-UPDATES
sfc-gh-aalam
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In replace_child, if the child of a parent has already been updated, the old child won't exist anymore, and an error could raise with the current code. However, if the child has already been updated with the new child, we should simply skip the update.
For this case, the original plan have 4 resolved snowflake plan node that is pointing to the same source plan, therefore updating the child of one parent automatically updates the other parents.