Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip child replace for new query compilation stage if the child has been updated already #2517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

Skip child replace for new query compilation stage if the child has been updated already #2517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/snowflake/snowpark/_internal/compiler/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,13 @@ def to_selectable(plan: LogicalPlan, query_generator: QueryGenerator) -> Selecta
raise ValueError(f"parent node {parent} is not valid for replacement.")

if old_child not in getattr(parent, "children_plan_nodes", parent.children):
raise ValueError(f"old_child {old_child} is not a child of parent {parent}.")
if new_child in getattr(parent, "children_plan_nodes", parent.children):
# the child has already been updated
return
else:
raise ValueError(
f"old_child {old_child} is not a child of parent {parent}."
)

if isinstance(parent, SnowflakePlan):
assert parent.source_plan is not None
Expand Down
Loading