Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-860063 Update documentation #964

Merged
merged 8 commits into from
Jul 31, 2023
Merged

SNOW-860063 Update documentation #964

merged 8 commits into from
Jul 31, 2023

Conversation

sfc-gh-stan
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@codecov
Copy link

codecov bot commented Jul 21, 2023 •
edited
Loading

Codecov Report

Merging #964 (8fd24bd) into main (dc1d496) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 8fd24bd differs from pull request most recent head 52baba3. Consider uploading reports for the commit 52baba3 to get more accurate results

@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files          51       51           
  Lines        9298     9298           
  Branches     1691     1691           
=======================================
  Hits         9144     9144           
  Misses         62       62           
  Partials       92       92
Files Changed Coverage Δ
src/snowflake/snowpark/functions.py 99.53% <ø> (ø)
src/snowflake/snowpark/session.py 98.80% <ø> (ø)
src/snowflake/snowpark/udf.py 97.40% <100.00%> (ø)
src/snowflake/snowpark/udtf.py 97.29% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-stan sfc-gh-stan changed the title SNOW-860063 Document required permission for creating dataframe related operations SNOW-860063 Update documentation Jul 28, 2023
@sfc-gh-stan sfc-gh-stan marked this pull request as ready for review July 28, 2023 21:51
@sfc-gh-stan sfc-gh-stan requested a review from a team as a code owner July 28, 2023 21:51
@sfc-gh-stan sfc-gh-stan added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 28, 2023
@sfc-gh-stan sfc-gh-stan mentioned this pull request Jul 31, 2023
Merged
5 tasks
sfc-gh-mabrennan
sfc-gh-mabrennan approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-mabrennan sfc-gh-mabrennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docstrings look great. I made a couple of suggestions. Thanks!

@sfc-gh-stan sfc-gh-stan enabled auto-merge (squash) July 31, 2023 18:07
@sfc-gh-stan sfc-gh-stan merged commit f6fe051 into main Jul 31, 2023
39 checks passed
@sfc-gh-stan sfc-gh-stan deleted the Add-documentation-for-create-dataframe branch July 31, 2023 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mabrennan sfc-gh-mabrennan sfc-gh-mabrennan approved these changes

@sfc-gh-sfan sfc-gh-sfan sfc-gh-sfan approved these changes

@sfc-gh-achandrasekaran sfc-gh-achandrasekaran Awaiting requested review from sfc-gh-achandrasekaran sfc-gh-achandrasekaran was automatically assigned from snowflakedb/snowpark-python-api

@sfc-gh-straut sfc-gh-straut Awaiting requested review from sfc-gh-straut

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-stan @sfc-gh-mabrennan @sfc-gh-sfan @sfc-gh-aalam