uncomment and fix java annotation tests #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies, had missed that formatting hadn't been applied. fixed and pushed |
|
Well if the tests pass, it works! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is somehow a really stupid way of doing it, but it seems to fix the tests, as well as some of my downstream issues *. Changing the type of the collected annotations without changing the api is probably dumb, but I figured it signalled intent without breaking any compatibility. It's not really necessary is it. Well anyway let me know your thoughts.
* I say 'some', because there's still an issue with scala annotations - I think it happens if you annotate both a case class and a parent trait with the same annotation, but with this change I don't have to worry about that problem because I can just use the upstream java annotations instead of trying to work around the issue. Might make a follow-up at some point...