Add condition to stop field management factors being recognized as traits #5289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bm743
changed the title
bm743
changed the title
| if ($t eq 'notes'){ | ||
| push @header_ids, 0; | ||
| } else { | ||
| next unless $t =~ /\|/; |
There was a problem hiding this comment.
$t =~ /|/; may not always be true even for valid traits (such as when trait abbreviations are used in a file) ???
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds condition to fix field management factors being recognized as traits in BrAPI call
Solution by @chris263
Fixes #5273
Checklist
/t/data/fixture/patches/./docshas been updated./jsto/js/source/legacy.