Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add condition to stop field management factors being recognized as traits #5289

Merged
merged 3 commits into from
Feb 13, 2025
+6 −5
Merged

Add condition to stop field management factors being recognized as traits #5289

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa0c999
Add condition to ensure loop is executed for traits and not field man…
bm743 Jan 29, 2025
b9d7843
Move condition filtering field management factors to after notes chec…
bm743 Feb 12, 2025
2e9d213
Comment out print statements in _BrAPI_.v1.t
bm743 Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions lib/CXGN/BrAPI/v1/Studies.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,11 +777,12 @@ sub studies_table {
#print STDERR Dumper \@trait_names;
my @header_ids;
foreach my $t (@trait_names) {
if ($t eq 'notes'){
push @header_ids, 0;
} else {
push @header_ids, SGN::Model::Cvterm->get_cvterm_row_from_trait_name($self->bcs_schema, $t)->cvterm_id();
}
if ($t eq 'notes'){
push @header_ids, 0;
} else {
next unless $t =~ /\|/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$t =~ /|/; may not always be true even for valid traits (such as when trait abbreviations are used in a file) ???

push @header_ids, SGN::Model::Cvterm->get_cvterm_row_from_trait_name($self->bcs_schema, $t)->cvterm_id();
}
}

my $start = $page_size*$page;
Expand Down