Fix test_xon_not_counted.py fanout port selection#22114
Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom Feb 5, 2026
Merged
Conversation
Follow test_pfc_counters.py, only select active port and convert fanout port to Linux interface name based on its OS. Move name conversion helper functions to device_utils.py. Signed-off-by: markxiao <markxiao@arista.com>
Collaborator
|
/azp run |
github-actions
bot
requested review from
XuChen-MSFT,
vmittal-msft and
xwjiang-ms
|
Azure Pipelines successfully started running 1 pipeline(s). |
bingwang-ms
approved these changes
Feb 5, 2026
Collaborator
bingwang-ms
left a comment
bingwang-ms
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the improvement.
bingwang-ms
added
Request for msft-202503 Branch
Request for 202511 branch
7 tasks
Contributor
Author
|
Manually cherry-pick to 202503: Azure/sonic-mgmt.msft#1008 |
abhishek-nexthop
pushed a commit
to nexthop-ai/sonic-mgmt
that referenced
this pull request
Feb 6, 2026
Follow test_pfc_counters.py, only select active port and convert fanout port to Linux interface name based on its OS. Move name conversion helper functions to device_utils.py. Signed-off-by: markxiao <markxiao@arista.com>
Anirudh-nokia
pushed a commit
to Anirudh-nokia/sonic-mgmt-fork
that referenced
this pull request
Feb 6, 2026
Follow test_pfc_counters.py, only select active port and convert fanout port to Linux interface name based on its OS. Move name conversion helper functions to device_utils.py. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: ayya <anirudh.ayya@nokia.com>
nnelluri-cisco
pushed a commit
to nnelluri-cisco/sonic-mgmt
that referenced
this pull request
Feb 12, 2026
Follow test_pfc_counters.py, only select active port and convert fanout port to Linux interface name based on its OS. Move name conversion helper functions to device_utils.py. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: nnelluri-cisco <nnelluri@cisco.com>
anilal-amd
pushed a commit
to anilal-amd/anilal-forked-sonic-mgmt
that referenced
this pull request
Feb 19, 2026
Follow test_pfc_counters.py, only select active port and convert fanout port to Linux interface name based on its OS. Move name conversion helper functions to device_utils.py. Signed-off-by: markxiao <markxiao@arista.com> Signed-off-by: Zhuohui Tan <zhuohui.tan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Follow test_pfc_counters.py, only select active port and convert fanout port to Linux interface name based on its OS.
Move name conversion helper functions to device_utils.py.
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Test failed due to using non-Sonic fanout and we need to select active port only
How did you do it?
Fix it by following test_pfc_counters.py and move helper functions to device_utils.py
How did you verify/test it?
test_xon_not_counted.py passed with EOS fanout
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation