[202503] Fix test_xon_not_counted.py fanout port selection#1008
Open
markx-arista wants to merge 1 commit intoAzure:202503from
Open
[202503] Fix test_xon_not_counted.py fanout port selection#1008markx-arista wants to merge 1 commit intoAzure:202503from
markx-arista wants to merge 1 commit intoAzure:202503from
Conversation
Follow test_pfc_counters.py, only select active port and convert fanout port to Linux interface name based on its OS. Move name conversion helper functions to device_utils.py. Signed-off-by: markxiao <markxiao@arista.com>
markx-arista
requested review from
XuChen-MSFT,
lipxu,
neethajohn and
wsycqyz
as code owners
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Follow test_pfc_counters.py, only select active port and convert fanout port to Linux interface name based on its OS.
Move name conversion helper functions to device_utils.py.
Manually cherry-pick of sonic-net/sonic-mgmt#22114
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Test failed due to using non-Sonic fanout and we need to select active port only
How did you do it?
Fix it by following test_pfc_counters.py and move helper functions to device_utils.py
How did you verify/test it?
test_xon_not_counted.py passed with EOS fanout
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation