Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: complete renaming of contract definition into data offer #840

Merged

Conversation

illfixit
Copy link
Collaborator

@illfixit illfixit commented Sep 20, 2024

What issues does this PR close?
closes #831 Inconsistent renaming "Contract Definition" to "Data Offer"

Checklist

@illfixit illfixit linked an issue Sep 20, 2024 that may be closed by this pull request
@illfixit illfixit marked this pull request as ready for review September 20, 2024 07:06
@illfixit illfixit enabled auto-merge (squash) September 20, 2024 07:07
Copy link
Collaborator

@kamilczaja kamilczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to fix the i18n gaps in the near future

@illfixit illfixit merged commit da9640a into main Sep 20, 2024
13 checks passed
@illfixit illfixit deleted the 831-inconsistent-renaming-contract-definition-to-data-offer branch September 20, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent renaming "Contract Definition" to "Data Offer"
2 participants