Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: complete renaming of contract definition into data offer #840

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ the detailed section referring to by linking pull requests or issues.

#### Patch

- Fixed gaps in renaming to "Data Offer"
([#831](https://github.com/sovity/edc-ui/issues/831))
- Replaced hints with info boxes in On Request data source
([#820](https://github.com/sovity/edc-ui/issues/820))
- Fixed cropping of Contract Offer Ids on catalog browser page
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,23 +63,18 @@ export class ContractDefinitionEditorDialog implements OnInit, OnDestroy {
)
.subscribe({
complete: () => {
this.notificationService.showInfo(
'Successfully created contract definition.',
);
this.notificationService.showInfo('Successfully created data offer.');
this.close({refreshList: true});
},
error: (error) => {
if (error.status == 409) {
this.notificationService.showError(
'Contract Definition ID already taken.',
);
this.notificationService.showError('Data offer ID already taken.');
} else if (error.status >= 500) {
this.notificationService.showError(
'Error creating contract definition: ' +
(error?.error?.message ?? '???'),
'Error creating data offer: ' + (error?.error?.message ?? '???'),
);
}
console.error('Error creating contract definition!', error);
console.error('Error creating data offer!', error);
},
});
}
Expand Down
Loading