Skip to content

Comments

Paraview 6 updates#192

Open
kwryankrattiger wants to merge 6 commits intospack:developfrom
kwryankrattiger:paraview_6_updates
Open

Paraview 6 updates#192
kwryankrattiger wants to merge 6 commits intospack:developfrom
kwryankrattiger:paraview_6_updates

Conversation

@kwryankrattiger
Copy link
Contributor

Updates for ParaView 6

@kwryankrattiger kwryankrattiger force-pushed the paraview_6_updates branch 2 times, most recently from 31aa625 to f8c53cc Compare July 9, 2025 20:30
Copy link
Member

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ParaView bites looks great

Copy link
Member

@vicentebolea vicentebolea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libxslt is failing in the CI

@tldahlgren tldahlgren requested a review from danlipsa August 11, 2025 18:21
@tldahlgren
Copy link
Contributor

Added remaining missing maintainer.

@tldahlgren
Copy link
Contributor

FYI. qt-tools has conflicts to resolve.

@kmorel
Copy link
Contributor

kmorel commented Dec 11, 2025

@kwryankrattiger I can't help but note that this PR is quite old and we are still waiting for ParaView 6 to be available in Spack. What is the status of this?

@tldahlgren
Copy link
Contributor

There are a couple of files with conflicts that need to be resolved.

@kwryankrattiger
Copy link
Contributor Author

@kwryankrattiger I can't help but note that this PR is quite old and we are still waiting for ParaView 6 to be available in Spack. What is the status of this?

Yes, it is quite old :(

The main blocker on this was that an unrelated package was getting stuck on a concretization error. To address this more systematically the X, GL, and Qt updates were extracted into separate PRs.

These two PRs that have since found themselves hung up in review:

There are a couple of files with conflicts that need to be resolved.

These are being ignored, there will be a rebase to only contain the paraview related changes at some point. I am hopeful to remaining two PRs will get merged sooner rather than later.

kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Dec 11, 2025
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Dec 17, 2025
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Dec 18, 2025
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Dec 18, 2025
mkrack pushed a commit to mkrack/spack-packages that referenced this pull request Dec 23, 2025
* Updates to X related packages spack#192

* fix typo in options

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>

---------

Co-authored-by: Wouter Deconinck <wdconinc@gmail.com>
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Jan 28, 2026
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Feb 17, 2026
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Feb 17, 2026
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Feb 17, 2026
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Feb 17, 2026
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Feb 17, 2026
johnwparent pushed a commit that referenced this pull request Feb 18, 2026
Updates to GL ecosystem to correctly link OpenGL provided by Spack built Mesa
johnwparent pushed a commit that referenced this pull request Feb 19, 2026
* Updates to better support Qt6 for related packages #192
kwryankrattiger added a commit to kwryankrattiger/spack-packages that referenced this pull request Feb 19, 2026
author Ryan Krattiger <80296582+kwryankrattiger@users.noreply.github.com> 1771535312 -0600
committer Ryan Krattiger <ryan.krattiger@kitware.com> 1771541345 -0600

parent b411447
author Ryan Krattiger <80296582+kwryankrattiger@users.noreply.github.com> 1771535312 -0600
committer Ryan Krattiger <ryan.krattiger@kitware.com> 1771541285 -0600

Updates to Qt6 related packages spack#192 (spack#2058)

* Updates to better support Qt6 for related packages spack#192
@spackbot-triage spackbot-triage bot requested a review from kmorel February 19, 2026 22:50
* VTKm -> Viskores transition
  * Drop `use_vtkm` variant for 6: (use variants rocm/cuda/fides)
  * External Viskores
* Dynamic loading GL with GLAD
* Qt6 support
* Variant for X11 (previously implicit with GLX)
It should be allowable to run paraview against a GL not in the DAG.
This is not a full fix to this issue. It is still possible to construct
cases where an externally built glib-bootstrap is not detected
correctly, or a package that depends on glib and glib-bootstrap will
always find the bootstrap version of glib-2.0. In order to handle those
cases correctly more thought is needed in how this should be expressed
via the package API/spec.
Newer versions (head of master) works with Qt >= 6.10. This should be
bumped or dropped for the next release.
Comment on lines +161 to +173
# TODO: Fix this in a more complete way
# This needs to be manually added to the PKG_CONFIG_PATH or it won't be detected by
# dependent packages reliably.
# If bootstrap is external append it to ensure that Spack paths are searched before
# system paths
# If it is built by Spack it should be safe to prepend.
if self.spec.satisfies("^glib-bootstrap"):
env.append_path("PKG_CONFIG_PATH", self.spec["glib-bootstrap"].prefix.lib.pkgconfig)
glib_bootstrap_spec = self.spec["glib-bootstrap"]
pkg_config_path = self.spec["glib-bootstrap"].prefix.lib.pkgconfig
if glib_bootstrap_spec.external:
env.append_path("PKG_CONFIG_PATH", pkg_config_path)
else:
env.prepend_path("PKG_CONFIG_PATH", pkg_config_path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root of the issue is the link dep of a build dep is not included in the PKG_CONFIG_PATH variable. It is labeled, oddly, as a runtime only dep. To fix that is going to require a lot more thought as we have to change logic that is buried inside of build environment and my first pass at that was incomplete. This is easier and fixes the most immediate case.

You can still have a case where glib and glib-bootstrap are both in the deps and the glib-2.0 is always detected as the bootstrap version even if that isn't what is wanted.

--

So on my system I have an external package configured also in this stack. This creates a problem with pkg-config search for glib-2.0 finds the wrong glib.

When we build the search path for spack we prepend all externals and then all non externals. This way we search the spack built prefixes first, then external prefixes. The external prefix that I have is not excluded and also contains the pkg-config files for all of my system packages. Including an external glib that doesn't satisfy the version constraint for gobject and is the wrong glib I'm general. So appending this package path always results in broken search in a common case.

So to "fix" this case I try to mimic the behavior of the build environment where spack installed packages are listed first, and externals are listed second. This is not a complete fix, but it gets past this common case for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants