fix: vertically center username in profile popup #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for biseo-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sanghou
reviewed
Mar 20, 2024
| @@ -43,6 +43,7 @@ export const Profile: React.FC<Props> = ({ displayName, onLogout }) => ( | |||
| w(100), | |||
| h(18), | |||
| padding.horizontal(8), | |||
| padding.vertical(2), | |||
| justify.between, | |||
| align.center, | |||
| ]} | |||
There was a problem hiding this comment.
명시적인 수치로 하는게 좋을지,
바깥쪽 div를 display:flex로 선언하고 align-items를 center로 주는게 좋을지 의견이 궁금합니다.
저희 명시적으로 이런쪽에 대한 규칙은 없었던 것 같아서 궁금합니다!
이후에 UI 인터페이스 확대 작업이랑 연결했을 때도 변화가 없다면 변경이 적은 작업인게 더 좋을 것 같습니다
There was a problem hiding this comment.
@Sanghou 기존에 있던 Profile styling을 위한 코드가 horizontal/vertical padding 들을 사용하고 있어서, 원래 코드와 비슷한 방법으로 해결을 하려고 하였습니다.
하지만 앞으로 UI 인터페이스를 확대 할 것을 생각하면 더 유연한 방법으로 해결하는 것이 도움이 될것 같네요.
제안 해주신 방법으로 다시 해결해 보겠습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약 *
It closes #468
스크린샷
이후 Task *