Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertically center username in profile popup #474

Merged
merged 1 commit into from
Mar 27, 2024
Merged

fix: vertically center username in profile popup #474

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/web/src/components/molecules/Profile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export const Profile: React.FC<Props> = ({ displayName, onLogout }) => (
w(100),
h(18),
padding.horizontal(8),
padding.vertical(2),
justify.between,
align.center,
]}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

명시적인 수치로 하는게 좋을지,
바깥쪽 div를 display:flex로 선언하고 align-items를 center로 주는게 좋을지 의견이 궁금합니다.

저희 명시적으로 이런쪽에 대한 규칙은 없었던 것 같아서 궁금합니다!

이후에 UI 인터페이스 확대 작업이랑 연결했을 때도 변화가 없다면 변경이 적은 작업인게 더 좋을 것 같습니다

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sanghou 기존에 있던 Profile styling을 위한 코드가 horizontal/vertical padding 들을 사용하고 있어서, 원래 코드와 비슷한 방법으로 해결을 하려고 하였습니다.
하지만 앞으로 UI 인터페이스를 확대 할 것을 생각하면 더 유연한 방법으로 해결하는 것이 도움이 될것 같네요.
제안 해주신 방법으로 다시 해결해 보겠습니다!

Expand Down
Loading