fix trigger using backward compatible trigger_metadata to allow multi trigger apps #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
force-pushed
the
enable_multi_trigger
branch
from
7c23d31
to
48cc74f
Compare
fibonacci1729
previously approved these changes
Aug 1, 2024
… trigger apps The trigger now uses the newer `trigger_metadata` method to obtain the trigger configuration which was introduced when Spin added support for multi trigger apps. This now enables the MQTT trigger to run alongside other triggers. Signed-off-by: karthik2804 <karthik.ganeshram@fermyon.com>
karthik2804
force-pushed
the
enable_multi_trigger
branch
from
48cc74f
to
863d9ce
Compare
fibonacci1729
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trigger now uses the newer
trigger_metadatamethod to obtain the trigger configuration introduced when Spin added support for multi-trigger apps. This now enables the MQTT trigger to run alongside other triggers.This PR also bumps the spin dependencies to
v2.6.0note: had to run a
cargo updatebecause of an issue withasync-channelcloses #34