Fix spfs-fuse task panicking on mask entry #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than use `unreachable!`, make `attr_from_entry` fallible and ignore mask entries inside `readdirplus`. Some log lines captured while debugging: ``` Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]: TRACE readdirplus add README.txt Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]: TRACE ... readdirplus add README.txt:false Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]: ERROR attr_from_entry encountered mask Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]: WARN Reply not sent for operation 49, replying with I/O error Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]: ERROR Error in readdirplus: task 142 panicked ``` Signed-off-by: J Robert Ray <jrray@imageworks.com>
rydrman
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than use
unreachable!, makeattr_from_entryfallible and ignore mask entries insidereaddirplus.Some log lines captured while debugging: