Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spfs-fuse task panicking on mask entry #1048

Merged
merged 1 commit into from
Jun 16, 2024
Merged

Fix spfs-fuse task panicking on mask entry #1048

merged 1 commit into from
Jun 16, 2024

Commits on Jun 14, 2024

  1. Fix spfs-fuse task panicking on mask entry

    Rather than use `unreachable!`, make `attr_from_entry` fallible and
    ignore mask entries inside `readdirplus`.
    
    Some log lines captured while debugging:
    ```
    Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]: TRACE readdirplus add README.txt
    Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]: TRACE ... readdirplus add README.txt:false
    Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]: ERROR attr_from_entry encountered mask
    Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]:  WARN Reply not sent for operation 49, replying with I/O error
    Jun 13 16:37:40 wolf0848.spimageworks.com spfs[195052]: ERROR Error in readdirplus: task 142 panicked
    ```
    
    Signed-off-by: J Robert Ray <jrray@imageworks.com>
    J Robert Ray committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    5bde6da View commit details
    Browse the repository at this point in the history