Fix a couple circular dependencies between crates #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the macros in spk-solve to its own crate, to break the cycle of spk-solve -> spk-solve-validation -> spk-solve (dev) The macro code was changed to remove many uses of re-exported symbols through `$crate`, since adding these dependencies would reintroduce a cyclic dependency. Signed-off-by: J Robert Ray <jrray@jrray.org>
Relocate a tests file to avoid a cyclic dependency:
spk_schema -> spk_schema_validators -> spk_schema (dev)
Signed-off-by: J Robert Ray <jrray@jrray.org>
Codecov Report
@@ Coverage Diff @@
## main #803 +/- ##
==========================================
- Coverage 53.97% 53.96% -0.01%
==========================================
Files 248 248
Lines 19303 19311 +8
==========================================
+ Hits 10419 10422 +3
- Misses 8884 8889 +5
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rydrman
approved these changes
Jul 29, 2023
Comment on lines
13
to
16
|
|
||
| #[cfg(test)] | ||
| #[path = "./validators_test.rs"] | ||
| mod validators_test; | ||
| // Tests for this module are in spk-schema/src/v0/validators_test.rs to avoid | ||
| // a cyclic crate dependency (the tests need spk_schema::v0). | ||
|
|
There was a problem hiding this comment.
This is the only change that I'm stuck on here - but I guess with the crates all blown apart into small pieces there's not much that can be done here aside from defining a separate spec and package type for use in the validator tests specifically. I suppose that's the right way to do it but it would be a lot of work, probably...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "cyclic deps" as can be seen being complained about in the rust-analyzer server log: