Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a couple circular dependencies between crates #803

Merged
merged 2 commits into from
Jul 29, 2023
Merged

Fix a couple circular dependencies between crates #803

merged 2 commits into from
Jul 29, 2023

Commits on Jul 19, 2023

  1. Fix cyclic crate dependency #1 

    Move the macros in spk-solve to its own crate, to break the cycle of

   spk-solve -> spk-solve-validation -> spk-solve (dev)

The macro code was changed to remove many uses of re-exported symbols
through `$crate`, since adding these dependencies would reintroduce a
cyclic dependency.

Signed-off-by: J Robert Ray <jrray@jrray.org>
    @jrray
    jrray committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    f1ae853 View commit details
    Browse the repository at this point in the history

  2. Fix cyclic crate dependency #2 

    Relocate a tests file to avoid a cyclic dependency:

    spk_schema -> spk_schema_validators -> spk_schema (dev)

Signed-off-by: J Robert Ray <jrray@jrray.org>
    @jrray
    jrray committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    db541a3 View commit details
    Browse the repository at this point in the history