-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capture unrecognized fields with lint #851
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
==========================================
- Coverage 53.55% 53.37% -0.18%
==========================================
Files 258 258
Lines 20466 20474 +8
==========================================
- Hits 10960 10928 -32
- Misses 9506 9546 +40 ☔ View full report in Codecov by Sentry. |
e8336fc
to
1a4aa72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're on the right track, just some course corrections here to save on duplicate code.
781fd74
to
3d6ce60
Compare
0cfe037
to
fadaa20
Compare
12078a4
to
0780595
Compare
179dace
to
41834c9
Compare
fa7569e
to
e8f7f43
Compare
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed error message when no similar configs are found. Added linting for EnvOp Signed-off-by: Nichol Yip <nyip@imageworks.com> Removed redudancy and simplified code. WIP: Generalizing LintedItem struct across all config types. Signed-off-by: Nichol Yip <nyip@imageworks.com> Added blanket implementation for LintedItem to generalize lints across all configs Signed-off-by: Nichol Yip <nyip@imageworks.com> Moved lint logic into separate file. Signed-off-by: Nichol Yip <nyip@imageworks.com> WIP: enum for lint messages Signed-off-by: Nichol Yip <nyip@imageworks.com> Moved lint error message inside new lint file. Fixed error message when unknown key is found. Implemented LintMessage enum for current variantions of lint error types. Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com> WIP: Adding lint feature to source spec Signed-off-by: Nichol Yip <nyip@imageworks.com>
Removed lint from spk-schema/crates/ident Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Fixed configs to use Lint proc macro to generate lint messages WIP: Add Lint proc macro for EnvOp and TestSpec Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
…-array crate instead. Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed linting errors and removed unused commented code. Signed-off-by: Nichol Yip <nyip@imageworks.com> Removed dead commented code and fixed du test with the correct sizes. Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed issue where no default source spec if found when no source provided Fixed issue with the default values for the meta struct when no values are provided Reverted du command tests back as it was related to the issue with the source spec. Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed typo in opentimelineio.spk.yaml Added render logic to linting command that caused some packages to return an error without it. Signed-off-by: Nichol Yip <nyip@imageworks.com> Added new line at EOF Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed changes from rebase that was not correctly added. Signed-off-by: Nichol Yip <nyip@imageworks.com> Removed shellexpand call from EnvOp Signed-off-by: Nichol Yip <nyip@imageworks.com> Moved crates to top level cargo.toml Changed linting feature to return an UnknownKey object instead of a generated string Modified new method for UnknownKey to store values needed to generated lint message Added enum for lints to support different kinds of lints Removed commented code Refactored render method and renamed render_lint -> render_to_string Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed changes from rebase Signed-off-by: Nichol Yip <nyip@imageworks.com> Fixed linting errors Signed-off-by: Nichol Yip <nyip@imageworks.com> WIP: Properly convert UncheckedBuildSpec -> BuildSpec Signed-off-by: Nichol Yip <nyip@imageworks.com> Implmented LintedBuildSpec struct to properly evaluate error if any, in the visitor method instead of the from implementation. Signed-off-by: Nichol Yip <nyip@imageworks.com> Removed redundant struct and replaced with using LintedItem instead. Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
e8f7f43
to
e03d04d
Compare
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
Signed-off-by: Nichol Yip <nyip@imageworks.com>
PR containing the current progress of updating the
Spk lint
command to capture typos and unrecognized config fields within the spk spec file. The current approach taken is to modify how the deserialize method works.Example:
Outputs the error: