-
Couldn't load subscription status.
- Fork 476
Fix Boolean is getter methods not properly mocked in Groovy <= 3 #2244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
92d866e to
8da8df0
Compare
spock-specs/src/test/groovy/org/spockframework/runtime/GroovyRuntimeUtilSpec.groovy
Outdated
Show resolved
Hide resolved
spock-specs/src/test/groovy/org/spockframework/runtime/GroovyRuntimeUtilSpec.groovy
Outdated
Show resolved
Hide resolved
Added tests to verify that boolean is getter work according to Groovy rules. Fixes spockframework#2131
8da8df0 to
285c01f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2244 +/- ##
============================================
+ Coverage 82.00% 82.04% +0.04%
Complexity 4752 4752
============================================
Files 465 465
Lines 14871 14871
Branches 1878 1878
============================================
+ Hits 12195 12201 +6
+ Misses 1988 1982 -6
Partials 688 688
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
Added tests to verify that boolean is getter work according to Groovy rules.
Fixes #2131