Skip to content

Conversation

@AndreasTu
Copy link
Member

@AndreasTu AndreasTu commented Oct 25, 2025

Added tests to verify that boolean is getter work according to Groovy rules.

Fixes #2131

@AndreasTu AndreasTu self-assigned this Oct 25, 2025
@AndreasTu AndreasTu marked this pull request as draft October 25, 2025 09:48
@AndreasTu AndreasTu changed the title Tests for boolean getter mocks Fix Boxed Boolean is getter methods are not properly mocked in Groovy <= 3 Oct 25, 2025
@AndreasTu AndreasTu changed the title Fix Boxed Boolean is getter methods are not properly mocked in Groovy <= 3 Fix Boolean is getter methods are not properly mocked in Groovy <= 3 Oct 25, 2025
@AndreasTu AndreasTu marked this pull request as ready for review October 25, 2025 11:20
@AndreasTu AndreasTu requested a review from Vampire October 25, 2025 11:20
Added tests to verify that boolean is getter work according to Groovy rules.

Fixes spockframework#2131
@AndreasTu AndreasTu changed the title Fix Boolean is getter methods are not properly mocked in Groovy <= 3 Fix Boolean is getter methods not properly mocked in Groovy <= 3 Oct 26, 2025
@AndreasTu AndreasTu requested a review from Vampire October 26, 2025 09:56
@AndreasTu AndreasTu added this to the 2.4-M7 milestone Oct 26, 2025
@AndreasTu AndreasTu enabled auto-merge (squash) October 26, 2025 09:58
@codecov
Copy link

codecov bot commented Oct 26, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.04%. Comparing base (c035dd4) to head (5c55ff6).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../org/spockframework/runtime/GroovyRuntimeUtil.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2244      +/-   ##
============================================
+ Coverage     82.00%   82.04%   +0.04%     
  Complexity     4752     4752              
============================================
  Files           465      465              
  Lines         14871    14871              
  Branches       1878     1878              
============================================
+ Hits          12195    12201       +6     
+ Misses         1988     1982       -6     
  Partials        688      688              
Files with missing lines Coverage Δ
.../org/spockframework/runtime/GroovyRuntimeUtil.java 82.97% <0.00%> (+6.38%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@Vampire Vampire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@AndreasTu AndreasTu merged commit 77ef17c into spockframework:master Oct 26, 2025
35 of 36 checks passed
@AndreasTu AndreasTu deleted the Mock_Issue_2131 branch October 26, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boxed Boolean getter methods prefixed by is are not properly mocked in Groovy <=3

2 participants