Switch to maven publish plugin for publishing #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
commented
May 8, 2024
| @@ -54,10 +55,6 @@ publishing { | |||
| artifactId = 'sort-gradle-dependencies-dist' | |||
| artifact shadowDistZip | |||
| } | |||
| app(MavenPublication) { | |||
| artifactId = 'sort-gradle-dependencies-app' | |||
There was a problem hiding this comment.
This one is created automatically by the plugin
ZacSweers
commented
May 8, 2024
| @@ -16,11 +16,5 @@ class LibConvention : Plugin<Project> { | |||
|
|
|||
| override fun apply(target: Project): Unit = target.run { | |||
| pluginManager.apply(BaseConvention::class.java) | |||
|
|
|||
| extensions.configure(JavaPluginExtension::class.java) { j -> | |||
| // We specifically don't want either of these artifacts on the app project | |||
There was a problem hiding this comment.
Handled automatically by the plugin when dokka is present
|
This is almost ready to merge.
|
autonomousapps
approved these changes
May 23, 2024
.github/workflows/publish.yml
Outdated
Comment on lines
44
to
46
| # TODO from the square side | ||
| ORG_GRADLE_PROJECT_signingInMemoryKeyId: ${{ secrets.TODO }} | ||
| ORG_GRADLE_PROJECT_signingInMemoryKeyPassword: ${{ secrets.TODO }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the project to use the maven publish plugin and is functionally equivalent to the artifacts published with the previous plugin infrastructure.
Also opportunistically updates gradle, develocity, and kotlin along the way