Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding start up commands for airflow #530

Merged
merged 15 commits into from
Nov 11, 2024
Merged

fix: Adding start up commands for airflow #530

merged 15 commits into from
Nov 11, 2024

Conversation

Maleware
Copy link
Contributor

@Maleware Maleware commented Nov 4, 2024 •
edited by siegfriedweber
Loading

Description

Adding certificates to python path at starting up Airflow

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author
Preview Give feedback

Reviewer
Preview Give feedback

Acceptance
Preview Give feedback

@Maleware Maleware self-assigned this Nov 5, 2024
@siegfriedweber siegfriedweber mentioned this pull request Nov 6, 2024
Closed
@Maleware Maleware marked this pull request as ready for review November 6, 2024 09:21
@Maleware Maleware mentioned this pull request Nov 6, 2024
Merged
siegfriedweber
siegfriedweber requested changes Nov 6, 2024
View reviewed changes
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/config.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/config.rs Outdated Show resolved Hide resolved
rust/operator-binary/src/config.rs Outdated Show resolved Hide resolved
siegfriedweber
siegfriedweber requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be added to the CHANGELOG, e.g.:

- Add support for OpenID Connect ([#524], [#530]).

rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Outdated Show resolved Hide resolved
rust/crd/src/authentication.rs Outdated Show resolved Hide resolved
rust/crd/src/lib.rs Show resolved Hide resolved
siegfriedweber
siegfriedweber approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@siegfriedweber siegfriedweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Maleware Maleware added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit 36b65a6 Nov 11, 2024
16 of 17 checks passed
@Maleware Maleware deleted the fix/oidc-env branch November 11, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siegfriedweber siegfriedweber siegfriedweber approved these changes

Assignees

@Maleware Maleware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Maleware @siegfriedweber