-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert to preferring IP addresses for Node listeners by default #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM. Can you please also update the docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Running on Openshift currently fails with: |
Fixed Clusterrole (this will be covered in a separate PR, so that this one can be merged):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved! will update the clusterrole for OS-compatability separately
Many thanks, happy to review! |
As we have merged stackabletech/listener-operator#244 there is no need for a special ListenerClass any more
As we have merged stackabletech/listener-operator#244 there is no need for a special ListenerClass any more
Description
Supersedes #243. Implementation side of stackabletech/operator-rs#903.
Definition of Done Checklist
Author
Reviewer
Acceptance