Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to preferring IP addresses for Node listeners by default #244

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 31, 2024

Description

Supersedes #243. Implementation side of stackabletech/operator-rs#903.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@nightkr nightkr requested review from sbernauer and a team October 31, 2024 13:59
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Can you please also update the docs?

Cargo.toml Outdated Show resolved Hide resolved
@nightkr
Copy link
Member Author

nightkr commented Oct 31, 2024

e1ff5b1

sbernauer
sbernauer previously approved these changes Oct 31, 2024
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbernauer sbernauer requested a review from adwk67 November 6, 2024 15:01
@adwk67
Copy link
Member

adwk67 commented Nov 6, 2024

Running on Openshift currently fails with:
failed to apply patch: unable to patch resource "listener-nginx-long-name-approaching-k8s-limits-0": ApiError: services "listener-nginx-long-name-approaching-k8s-limits-0" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>: Forbidden

@adwk67
Copy link
Member

adwk67 commented Nov 6, 2024

Fixed Clusterrole (this will be covered in a separate PR, so that this one can be merged):

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
...
rules:
...
  resources:
  - persistentvolumes
  verbs:
  - get
  - list
  - watch
  - patch
  - create
  - delete
- apiGroups:
  - ""
  resources:
  - nodes
  - persistentvolumes
  - persistentvolumes/finalizers
  - persistentvolumeclaims
  - endpoints
  verbs:
  - create
  - update
  - patch
  - get
  - list
  - watch
...
- apiGroups:
  - listeners.stackable.tech
  resources:
  - listeners
  - listeners/finalizers
  - listeners/status
  - podlisteners
  verbs:
  - patch
  - create
  - delete
  - update
...

Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! will update the clusterrole for OS-compatability separately

@sbernauer
Copy link
Member

Many thanks, happy to review!

@sbernauer sbernauer added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 0b38a1c Nov 6, 2024
17 checks passed
@sbernauer sbernauer deleted the feature/smart-preferred-address-type branch November 6, 2024 16:02
sbernauer added a commit to stackabletech/kafka-operator that referenced this pull request Nov 7, 2024
As we have merged
stackabletech/listener-operator#244 there is no
need for a special ListenerClass any more
github-merge-queue bot pushed a commit to stackabletech/kafka-operator that referenced this pull request Nov 7, 2024
As we have merged
stackabletech/listener-operator#244 there is no
need for a special ListenerClass any more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants