Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "smart" preferred address types #903

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Oct 31, 2024

Description

This adds a new HostnameConservative preferred address type which uses IP addresses for Node addresses. This should be closer to the old defaults of 0.78.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@nightkr nightkr marked this pull request as draft October 31, 2024 12:19
@nightkr
Copy link
Member Author

nightkr commented Oct 31, 2024

This will require all operators that read ListenerClass to also be bumped (stackabletech/issues#661) ASAP. AFAICT this mostly impacts list-op (obviously) and secret-op (which just needs an op-rs version bump).

@nightkr
Copy link
Member Author

nightkr commented Oct 31, 2024

list-op PR: stackabletech/listener-operator#244

Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a minor style question

@nightkr nightkr marked this pull request as ready for review October 31, 2024 15:21
@sbernauer
Copy link
Member

We talked about this Munich and decided to go with this :)

@nightkr nightkr added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit c79d997 Nov 5, 2024
10 checks passed
@nightkr nightkr deleted the feature/smart-preferred-address-type branch November 5, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants