Skip to content

Conversation

@m-kus
Copy link
Member

@m-kus m-kus commented Sep 26, 2025

TL;DR

Simplified the bridge node architecture by removing the file sink component and streamlining the API response structure.

What changed?

  • Removed the file_sink.rs module which was responsible for writing sparse roots to JSON files
  • Renamed mmr_db_path to db_path in AppConfig to better reflect its purpose
  • Modified the ApiResponseBody enum:
    • Added an Empty variant for responses that don't need to return data
    • Removed the AddBlock variant as it's no longer needed
  • Updated the add_block method in AppClient to return Result<(), anyhow::Error> instead of Result<SparseRoots, anyhow::Error>
  • Simplified the indexer implementation by removing the sparse roots sink logic
  • Removed related CLI arguments for sparse roots output directory and shard size

@m-kus m-kus force-pushed the m-kus/index-chain-state branch from d01b7a8 to 6fbb925 Compare September 29, 2025 10:27
@m-kus m-kus changed the title Index and serve block headers backend: remove file sink Sep 29, 2025
@m-kus m-kus marked this pull request as ready for review September 29, 2025 10:29
@m-kus m-kus requested a review from maciejka as a code owner September 29, 2025 10:29
@m-kus m-kus force-pushed the m-kus/index-chain-state branch from 6fbb925 to 4365521 Compare September 29, 2025 10:31
Copy link
Member Author

m-kus commented Sep 29, 2025

@m-kus m-kus changed the base branch from main to graphite-base/375 October 3, 2025 16:19
@m-kus m-kus force-pushed the m-kus/index-chain-state branch from 4365521 to 69221cc Compare October 3, 2025 16:19
@m-kus m-kus changed the base branch from graphite-base/375 to 10-03-fix_typo October 3, 2025 16:19
This was referenced Oct 3, 2025
Base automatically changed from 10-03-fix_typo to main October 6, 2025 09:00
@m-kus m-kus merged commit 07b0bf0 into main Oct 6, 2025
9 checks passed
@m-kus m-kus deleted the m-kus/index-chain-state branch October 6, 2025 19:16
m-kus added a commit that referenced this pull request Oct 8, 2025
maciejka pushed a commit that referenced this pull request Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants