-
Notifications
You must be signed in to change notification settings - Fork 55
Single writer/multiple reader MMR store #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
d3336ab to
a621be0
Compare
|
Does it make sense to use sqllite if it require maintaining extra logic to manage connections? Wouldn't a good old postgres be a better choice? |
|
External PG seems like an overkill, embedded db is a simpler option. We do need acid transaction though (to avoid weird indexing issues), so sqlite is a good choice. |
fdd9498 to
5ffb65f
Compare
4365521 to
69221cc
Compare
5ffb65f to
e967826
Compare
e967826 to
f8254bd
Compare
69221cc to
295b2ac
Compare
f8254bd to
f87e158
Compare

This PR replaces the SQLite store backend from rust-accumulators with a new one, more configurable. The implementation:
MMRStorethat implements theBlockMMRStoretrait with SQLite backendBlockMMRto use the new storage interfaceThe PR also adds the
async-traitdependency and integrates theaccumulatorscrate from the workspace dependencies.