Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(starknet_integration_tests): create load_and_validate_config… #4028

Merged
merged 2 commits into from
Feb 16, 2025

Conversation

nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Feb 9, 2025

… function

commit-id:7c11e54a


Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

@reviewable-StarkWare
Copy link

This change is Reviewable

@nadin-Starkware nadin-Starkware force-pushed the spr/main/7c11e54a branch 2 times, most recently from 5fbb9bc to 44ce5cc Compare February 9, 2025 10:34
@nadin-Starkware nadin-Starkware force-pushed the spr/main/7c11e54a branch 3 times, most recently from 23ea6c3 to bb6b652 Compare February 9, 2025 11:13
@nadin-Starkware nadin-Starkware force-pushed the spr/main/7c11e54a branch 2 times, most recently from f7843a6 to 6b1cb44 Compare February 9, 2025 11:52
Copy link
Contributor

@lev-starkware lev-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware changed the title refactor(starknet_integration_tests): create load_and_validate_config function refactor(starknet_integration_tests): create load_and_validate_config… Feb 16, 2025
@nadin-Starkware nadin-Starkware changed the base branch from spr/main/d3b61b51 to main February 16, 2025 12:00
@nadin-Starkware nadin-Starkware added this pull request to the merge queue Feb 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2025
Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware added this pull request to the merge queue Feb 16, 2025
Merged via the queue into main with commit f94da56 Feb 16, 2025
19 of 27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants